fix: improve path and package resolution #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests for this. Removed src/main/java from file path calculation.
This was referenced Mar 18, 2021
appland-release
pushed a commit
that referenced
this pull request
Mar 18, 2021
## [1.0.2](v1.0.1...v1.0.2) (2021-03-18) ### Bug Fixes * improve path and package resolution ([#62](#62)) ([c3ba3df](c3ba3df))
|
🎉 This PR is included in version 1.0.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
hleb-rubanau
pushed a commit
to hleb-rubanau/appmap-java
that referenced
this pull request
Apr 13, 2021
# 1.0.0 (2021-04-13) ### Bug Fixes * **gradle:** add debugging output ([8b63cfa](8b63cfa)) * **gradle:** add debugging output ([e577d30](e577d30)) * **gradle:** alternative way of specifying nexus credentials ([2df78dd](2df78dd)) * **gradle:** alternative way of specifying nexus credentials ([a018510](a018510)) * **gradle:** broken gradle directives ([b529ea2](b529ea2)) * **gradle:** fix typo ([7d11ffa](7d11ffa)) * **gradle:** troubleshoot testenv ([80e7b29](80e7b29)) * **gradle:** troubleshoot testenv ([5c16f70](5c16f70)) * Allow classes compiled without locals to be hooked ([0e0a0d3](0e0a0d3)) * Capture exceptions thrown from SQL interfaces ([9d1e66f](9d1e66f)) * disable http client requests ([getappmap#60](https://github.com/hleb-rubanau/appmap-java/issues/60)) ([2131d82](2131d82)) * Don't append System path to class pools ([681d74e](681d74e)) * improve path and package resolution ([getappmap#62](https://github.com/hleb-rubanau/appmap-java/issues/62)) ([c3ba3df](c3ba3df)) * Provide better error message when encountering an unknown event ([c69a877](c69a877)) ### Features * **docs:** improve CI documentation and also trigger the relase ([e6b5a8e](e6b5a8e)) * AppMap Maven plugin ([getappmap#46](https://github.com/hleb-rubanau/appmap-java/issues/46)) ([1798df2](1798df2)) * appmap.yml errors are logged to stderr ([e746253](e746253))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #57
This removes hard coded path prefixes from the source file path heuristics and fixes a potential null access when reading a class package.