Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting an inbound connection error can lead to InvalidStreamIDForPeer errors when acting as a client. #101

Closed
Lukasa opened this issue Apr 16, 2019 · 0 comments · Fixed by #102

Comments

@Lukasa
Copy link
Contributor

Lukasa commented Apr 16, 2019

The code that handles shutting down on inboundConnectionError tends to hit InvalidStreamIDForPeer. This is because we attempt to send a GOAWAY with lastStreamID set to .maxID, which is technically an invalid stream ID for the peer. We should modify the check here, as it's reasonable to want to set .maxID in this case, even though the server cannot technically emit such a stream ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant