Add swift experimental-destination install subcommand
#6023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
reviewed
Jan 6, 2023
| let cwd = fileSystem.currentWorkingDirectory, | ||
| let bundlePath = try? AbsolutePath(validating: bundlePathOrURL, relativeTo: cwd) | ||
| { | ||
| try fileSystem.move(from: bundlePath, to: destinationsDirectory) |
tomerd
reviewed
Jan 6, 2023
|
|
||
| let observabilitySystem = ObservabilitySystem( | ||
| SwiftToolObservabilityHandler(outputStream: stdoutStream, logLevel: .warning) | ||
| ) |
There was a problem hiding this comment.
if this is a repeated pattern we can potential define a SwiftToolObservabilitySystem that takes optional output stream and log level but defaults to stdout and warn
MaxDesiatov
force-pushed
the
maxd/destination-install-subcommand
branch
from
a192041 to
a48658d
Compare
MaxDesiatov
changed the base branch from
main
to
maxd/httpclient-async-execute
MaxDesiatov
force-pushed
the
maxd/destination-install-subcommand
branch
from
a48658d to
1299e15
Compare
MaxDesiatov
force-pushed
the
maxd/httpclient-async-execute
branch
7 times, most recently
from
b52f9d4 to
3e91487
Compare
MaxDesiatov
force-pushed
the
maxd/httpclient-async-execute
branch
4 times, most recently
from
47191c8 to
219ede1
Compare
MaxDesiatov
force-pushed
the
maxd/destination-install-subcommand
branch
from
3c19a23 to
ad41134
Compare
MaxDesiatov
requested review from
abertelrud,
neonichu and
elsh
as code owners
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
…xd/destination-install-subcommand # Conflicts: # Sources/SPMTestSupport/MockHashAlgorithm.swift
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci test Windows |
|
@swift-ci test Windows |
|
@swift-ci smoke test |
|
@swift-ci test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #6127.
Motivation:
Cross-compilation destinations pitch includes
installsubcommand for installing artifact bundles.Modifications:
Added new
InstallDestinationsubcommand that takes a single argument for a bundle to install from.Result:
swift experimental-destination installis available for installing destination bundles.