Registry configuration - security #6159
Conversation
yim-lee
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
| self.certificateRevocation = nil | ||
| } | ||
|
|
||
| mutating func merge(_ other: ValidationChecks) { |
There was a problem hiding this comment.
this is more of an override than a merge? at least at the value level
| case packageOverrides | ||
| } | ||
|
|
||
| public init(from decoder: Decoder) throws { |
There was a problem hiding this comment.
curios why we need the manual decoding?
There was a problem hiding this comment.
It thinks packageOverrides is an array instead of a dictionary IIRC.
| { | ||
| "registries": {}, | ||
| "security": { | ||
| "packageOverrides": { |
There was a problem hiding this comment.
do we need a test that checks the various levels of overrides / merge behavior?
There was a problem hiding this comment.
This is what this test and others (e.g., testGetSigning_scopeOverride) do.
There was a problem hiding this comment.
right. I was thinking a test that checks package override of scope, scope override of registry, and registry override of global all in the same config - ie stacked up on top of each other. maybe already covered and I missed it
Implement new `security` configuration per registry publish proposal
yim-lee
force-pushed
the
registry-security-config
branch
from
8409a1a to
5d4b3f0
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
|
@swift-ci please smoke test |
|
looks great 👍 |
Implement new
securityconfiguration per registry publish proposal