-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary decoding likely has 32bit issues with large data sizes #1377
Comments
fyi - The C++ upstream code seem to use |
Correction on that comment - |
If there's a 2GB limit, we should still write it out as |
I'm going to go ahead and close this, I doing another pass, and don't immediately see issues, so at this point I'd suggest we treat them as bugs if found instead of keeping this open longer term without any clear next steps. |
Like what #1375 fixed, it looks like we've got a few cases (
getFieldBodyBytes(count:)
,consume(length:)
, ...) where because the internals of the BinaryDecoder useInt
we could have failures in a 32bit build.The text was updated successfully, but these errors were encountered: