Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows build is broken #92

Closed
karwa opened this issue Jun 11, 2022 · 3 comments · Fixed by #93
Closed

Windows build is broken #92

karwa opened this issue Jun 11, 2022 · 3 comments · Fixed by #93
Assignees
@lorentey

Comments

@karwa
Copy link

karwa commented Jun 11, 2022 

D:\a\swift-url\swift-url\.build\checkouts\swift-system\Sources\System\FileOperations.swift:445:7: error: cannot find 'system_ftruncate' in scope

😐

I don't like it when my builds break because swift-system published a release without even testing it. Please never do that again.
@lorentey lorentey self-assigned this Jun 11, 2022
@lorentey lorentey linked a pull request Jun 11, 2022 that will close this issue
Revert "FileOperations: Add Windows implementation for FileDescriptor.resize(to:)" #93
Merged
@lorentey lorentey mentioned this issue Jun 11, 2022
Merged
@lorentey
Copy link
Member

I reverted the offending commit in #93. I'll tag a point release once I verify this resolves this issue.

@lorentey
Copy link
Member

Noted.

@lorentey
Copy link
Member

Version 1.2.1 is out fixing the Windows port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorentey lorentey

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lorentey @karwa