Add an api to trace an function and run it with XLA compilation. #23868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test tensorflow |
pschuh
approved these changes
Apr 8, 2019
rxwei
reviewed
Apr 8, 2019
| @@ -218,7 +218,8 @@ private class TraceContext { | |||
|
|
|||
| /// Execute the trace graph function, and return the list of output tensors | |||
| /// from the trace execution. These output tensors are owned by the caller. | |||
| func execute(traceeInputs: [_AnyTensorHandle]) -> [CTensorHandle] { | |||
| func execute( | |||
| traceeInputs: [_AnyTensorHandle], useXla: Bool = false) -> [CTensorHandle] { | |||
| // Trace the given function to generate a TF graph and return a closure | ||
| // that can be used to launch the graph. | ||
| public func _graph<In : TensorGroup, Out : TensorGroup>( | ||
| _ fn: (In) -> Out, useXla: Bool = false |
| ) -> (In) -> Out { | ||
| let traceContext: TraceContext = withoutActuallyEscaping(fn) { escapableFn in | ||
| let wrappedFn = { | ||
| (inputs: [CTensorHandle]) -> [CTensorHandle] in |
There was a problem hiding this comment.
I think this could be moved to the previous line without going over the column limit.
bgogul
added a commit
to bgogul/swift
that referenced
this pull request
Apr 12, 2019
rxwei
pushed a commit
that referenced
this pull request
Apr 13, 2019
rxwei
pushed a commit
to rxwei/swift
that referenced
this pull request
May 11, 2019
rxwei
pushed a commit
to rxwei/swift
that referenced
this pull request
May 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an API to trace a function that takes a
TensorGroupand returns aTensorGroup. The new API also takes an optionaluseXLAargument that enables XLA compilation when executing the traced graph.This is one of the several PRs needed for https://bugs.swift.org/browse/TF-406