Be smarter with django requirements version #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
applegrew
added a commit
that referenced
this pull request
Mar 12, 2013
Be smarter with django requirements version
|
Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Feb. 26, 2013 Django 1.5 has been released, so if you say that your module requires Django, setup will automatically install 1.5.
If it's convenient for new project that's not the case for old one's...
In this case best options are to require a decent version of Django for which we are sure django-select2 is fully compatible.
In this pull request I've set it to Django>=1.3
Another option is to remove django requirement as it let user make their own choice.