Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

BsonReader/Writer obsolete #27

Open
GarethPikPok opened this issue Dec 12, 2019 · 5 comments
Open

BsonReader/Writer obsolete #27

GarethPikPok opened this issue Dec 12, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@GarethPikPok
Copy link

Description

Using BsonReader and BsonWriter currently introduce the following warning:
warning CS0618: 'BsonWriter' is obsolete: 'BSON reading and writing has been moved to its own package. See https://www.nuget.org/packages/Newtonsoft.Json.Bson for more details.'

Why we need this

Bson is a much more compact and efficient file format. It is preferable for our project to use Bson.

Suggested solution

Either: A new package to handle Bson support OR extend this package to use the new Bson package.

@GarethPikPok GarethPikPok added the enhancement New feature or request label Dec 12, 2019
@applejag applejag self-assigned this Dec 13, 2019
@applejag
Copy link
Owner

Good note! Somewhat hoping this feature request would come later but it's interesting to pick up. Much smaller project than Newtonsoft.Json so it should be all fine.

Thanks for using the Newtonsoft.Json-for-Unity project!

@GarethPikPok
Copy link
Author

It's likely that for now I'll continue to use this project and suppress the obsolete warnings :) Looking forward to having the Bson plugin! Thanks for your hard work :) Take it easy over Christmas though!

@applejag
Copy link
Owner

applejag commented Dec 13, 2019

I think (haven't read through the source thoroughly yet) that Newtonsoft.Json.Bson actually don't use any DLR/Reflection.Emit code, so it would theoretically be all safe to just download the DLL from NuGet and put it into your Assets folder, even for AOT builds.

Adding Bson is just a matter of deploying the package to the registry, and preferably some CI in between for automated testing. You will see it pop up in the Unity Package Manager as available for download once it's deployed, then you can switch over to using the package instead.

And good Christmas spirit ;) 🎄 I want some time for adventofcode too. But soonTM

@victor-kallai
Copy link

@jilleJr Hello, any news on this feature?

@applejag
Copy link
Owner

@victor-kallai No progress I'm sorry to say. It's quite far down in my priority list. Have not looked into how difficult it is, if it's on the easier side then I'll consider doing it sooner than later.

Can't promise anything though, I'm very obstructed by life at the moment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants