Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TyphoonInjectionAware #115

Closed
jasperblues opened this issue Dec 5, 2013 · 3 comments
Closed

TyphoonInjectionAware #115

jasperblues opened this issue Dec 5, 2013 · 3 comments
Labels

Comments

@jasperblues
Copy link
Member

  • Can we call this TyphoonComponentFactoryAware ?

. . . meaning the class wishes to do the reverse of dependency injection - using the factory as a service locator

Also, on the interface the factory is type id - is this so we can return an assembly type?

  • Can we add some API doc to this class.
  • Can we add some users docs (not sure what page to put the user docs on).
@ghost ghost assigned rhgills Dec 5, 2013
@rhgills
Copy link
Contributor

rhgills commented Dec 5, 2013

TyphoonComponentFactoryAware seems better, I agree. I just renamed that.

Originally it was, but I think it might be better to type that to TyphoonComponentFactory and have the user cast it appropriately.

We should document, which should be fairly simple as the class is fairly simple.

@rhgills
Copy link
Contributor

rhgills commented Dec 5, 2013

Thinking about this more, we definitely should have a type TyphoonComponentFactory, especially in the case where you're using a component with an XML assembly.

Changed and pushed.

@jasperblues
Copy link
Member Author

Ok. . . perhaps we should push to CoocaPods as well? That way I can update this question:

http://stackoverflow.com/questions/20405636/typhoon-injecting-a-view-controller-provider/20414089#20414089

I'll push as v1.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants