Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Commits. #215

Closed
stefanpenner opened this issue May 1, 2014 · 3 comments
Closed

Missing Commits. #215

stefanpenner opened this issue May 1, 2014 · 3 comments

Comments

@stefanpenner
Copy link

It appears that 6c2d40beb9a7952baccb5e0ede1a20ad31e08080 was once in the mainline, but it is no longer. Whats the motivation for rewriting history?

@jasperblues
Copy link
Member

Do you have any idea what the missing commit was?

It was probably either:

  • A few times I've tested a bug-fix or new feature in a hurry, then pushed a remote tag for CoocaPods. Then pulled it back again to add a few more fixes. . . (I'm not sure if pulling a remote tag removes a commit though?)
  • Someone did something that they thought was embarrassing and took it out, instead of just pushing a new commit. (please don't do this!).

I'm quite sure there's no malicious reason. (Typhoon is not like openSSL. Either it works or it crashes).

@jasperblues
Copy link
Member

@stefanpenner

If you don't have any more comments we'll close this issue. Thanks for your concern.

  • Each build that we tag / push to CocoaPods undergoes stringent quality checks. We maintain high test coverage.
  • We release fixes and enhancements regularly.

At the same time Typhoon is made by volunteers who contribute their own time (and sometimes $$) to bring something like this to the community. Its released "as-is" and without warranty (Apache2.0).

@jasperblues
Copy link
Member

Ah, I know what this is now.

When pushing minor fixes or enhancements during the course of using Typhoon on a project, I got trigger happy tagging a micro-version. Rather than bumping the micro version again, the remote tag was removed and associated with another commit a very short time later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants