Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alpha in TyphoonUIColorTypeConverter #181

Closed
eriksundin opened this issue Feb 23, 2014 · 7 comments
Closed

Support alpha in TyphoonUIColorTypeConverter #181

eriksundin opened this issue Feb 23, 2014 · 7 comments

Comments

@eriksundin
Copy link
Contributor

A suggested enhancement to TyphoonUIColorTypeConverter, add the following supported formats:

Hex with alpha, #AARRGGBB
CSS style: rgb(r,g,b) and rgba(r,g,b,a)

@jasperblues
Copy link
Member

👍

1 similar comment
@alexgarbarev
Copy link
Contributor

👍

@eriksundin
Copy link
Contributor Author

@jasperblues About the code review process. Need a refresh of my memory. Did we decide on to always mark issues ready-for-review before closing it, then someone else in the team review/close it?

@jasperblues
Copy link
Member

@eriksundin yes we decided to do that. . . This is a really simple one, but I guess we could stick to it out of consistency.

@jasperblues
Copy link
Member

@eriksundin

So just for clarification, the process is.

  • Finish a feature. And push to main branch. Mark it 'ready for review'
  • Whoever is around can review. Reviewer can either close it (simple case) or b) raise for discussion. in the latter case we'll try to gain consensus before closing.

This process helped a lot with eg #138

@eriksundin
Copy link
Contributor Author

Great @jasperblues, thanks for the clarification. Yeah, figured this particular issue be somewhere in the grey zone. I think its good to stick to it if it's at least a change of some extent and it's not a question of a github issue-less refactoring or change.

@jasperblues
Copy link
Member

Yup we may as we'll just follow it for all tickets great and small. Even if the implementation approach is simple/low-risk it'll keep each other informed.

@eriksundin eriksundin removed their assignment Dec 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants