-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support alpha in TyphoonUIColorTypeConverter #181
Comments
👍 |
1 similar comment
👍 |
@jasperblues About the code review process. Need a refresh of my memory. Did we decide on to always mark issues ready-for-review before closing it, then someone else in the team review/close it? |
@eriksundin yes we decided to do that. . . This is a really simple one, but I guess we could stick to it out of consistency. |
So just for clarification, the process is.
This process helped a lot with eg #138 |
Great @jasperblues, thanks for the clarification. Yeah, figured this particular issue be somewhere in the grey zone. I think its good to stick to it if it's at least a change of some extent and it's not a question of a github issue-less refactoring or change. |
Yup we may as we'll just follow it for all tickets great and small. Even if the implementation approach is simple/low-risk it'll keep each other informed. |
A suggested enhancement to TyphoonUIColorTypeConverter, add the following supported formats:
Hex with alpha, #AARRGGBB
CSS style: rgb(r,g,b) and rgba(r,g,b,a)
The text was updated successfully, but these errors were encountered: