Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][compiler-v2] Location information in bytecode verification bugs could be improved #11925

Closed
vineethk opened this issue Feb 6, 2024 · 1 comment
Labels
bug Something isn't working compiler-v2 stale-exempt Prevents issues from being automatically marked and closed as stale

Comments

@vineethk
Copy link
Contributor

vineethk commented Feb 6, 2024

🐛 Bug

PR #11923 added bytecode verification checks at the end of compilation for compiler v2. If this verification fails due to a bug in the compiler, the location is usually the entire module: it would be nice to have more precise location information.

This issue is slightly hard to reproduce, as you would need to introduce a bug in the compiler to make it fail bytecode verification (an easy way to comment out the ability checks, and run the compiler on code that would have failed ability checks).

Once #11923 lands, third_party/move/move-compiler-v2/tests/bytecode-verify-failure/equality.exp demonstrates this issue.

@vineethk vineethk added bug Something isn't working compiler-v2 labels Feb 6, 2024
@vineethk vineethk moved this from 🆕 New to For Grabs in Move Language and Runtime Feb 6, 2024
@vineethk vineethk moved this from For Grabs to 🆕 New in Move Language and Runtime Feb 6, 2024
@sausagee sausagee added the stale-exempt Prevents issues from being automatically marked and closed as stale label Feb 8, 2024
@wrwg wrwg moved this from 🆕 New to 📋 Backlog in Move Language and Runtime Feb 29, 2024
@vineethk
Copy link
Contributor Author

Closing as fixed by #12534.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Move Language and Runtime Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compiler-v2 stale-exempt Prevents issues from being automatically marked and closed as stale
Projects
Status: Done
Development

No branches or pull requests

2 participants