Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] When JWT verification fails the faucet returns 500 but should return 4xx #15560

Open
banool opened this issue Dec 11, 2024 · 2 comments
Open
Labels
bug Something isn't working faucet

Comments

@banool
Copy link
Contributor

banool commented Dec 11, 2024

🐛 Bug

A clear and concise description of what the bug is.
To report a security issue, please email [email protected].

To reproduce

Make a request to the faucet with an invalid JWT, you will see a response like this with a 500 status code:

{
    "message": "Error(46): Failed to verify JWT token: []",
    "error_code": "CheckerError",
    "rejection_reasons": [],
    "txn_hashes": []
}

Expected Behavior

The user gets the same error body but with a 4xx instead.

System information

N/A

Additional context

Add any other context about the problem here.

@banool banool added bug Something isn't working faucet labels Dec 11, 2024
@VesperQuartz
Copy link

How do you get valid JWT token?

@banool
Copy link
Contributor Author

banool commented Dec 16, 2024

You must use https://aptos.dev/network/faucet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working faucet
Projects
None yet
Development

No branches or pull requests

2 participants