Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files explicitly passed as a parameter with --files should not get ignored #263

Closed
bingen opened this issue Nov 7, 2018 · 0 comments
Closed

Files explicitly passed as a parameter with --files should not get ignored #263

bingen opened this issue Nov 7, 2018 · 0 comments
Assignees
@0xGabi
Labels
🐛 bug An unexpected behavior of the API
Milestone
Aragon DAC Dec Sp...

Comments

@bingen
Copy link
Contributor

bingen commented Nov 7, 2018

Explicitly added files should take precedence over .gitignore. Right now if you run aragon run --files app/build (or aragon publish) but you have build in .gitignore contents in that folder would not be published.
Relevant lines were:
https://github.com/aragon/aragon-cli/blob/master/src/commands/apm_cmds/publish.js#L198
https://github.com/aragon/aragon-cli/blob/master/src/commands/apm_cmds/publish.js#L211
@sohkai sohkai added the 🐛 bug An unexpected behavior of the API label Nov 7, 2018
@0xGabi 0xGabi added this to the Aragon DAC Dec Sprint milestone Dec 15, 2018
@0xGabi 0xGabi self-assigned this Dec 31, 2018
@0xGabi 0xGabi mentioned this issue Dec 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xGabi 0xGabi

Labels
🐛 bug An unexpected behavior of the API
Projects
None yet
Milestone
Aragon DAC Dec Sprint
Development

No branches or pull requests
3 participants
@bingen @sohkai @0xGabi