Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create dao with [email protected] #321

Closed
kernelwhisperer opened this issue Jan 4, 2019 · 14 comments
Closed

Cannot create dao with [email protected] #321

kernelwhisperer opened this issue Jan 4, 2019 · 14 comments
Assignees
Labels
🐛 bug An unexpected behavior of the API

Comments

@kernelwhisperer
Copy link
Contributor

Doing aragon dao new on master gets stuck after sending the transaction:

 ✔ Fetching kit bare-kit.aragonpm.eth@latest
 ⠇ Create new DAO from kit
   Checking DAO

This works fine with v5.2.2.
Looking at the diff I suspect is because of #302 . Maybe aragen needs to be rebuilt?

@0xGabi 0xGabi added the 🐛 bug An unexpected behavior of the API label Jan 4, 2019
@0xGabi
Copy link
Contributor

0xGabi commented Jan 4, 2019

@sohkai In case aragen is rebuild would be great opportunity to include the changes needed to solve: #246

@sohkai
Copy link
Contributor

sohkai commented Jan 11, 2019

@0x6431346e could you double check by pinning ganache-core to the old version and seeing if it still works?

We should bump the version of ganache in aragen and release it with aragon/aragen#24.

@kernelwhisperer
Copy link
Contributor Author

@sohkai It works with pinning the old version.

@0xGabi
Copy link
Contributor

0xGabi commented Jan 14, 2019

@sohkai , @0x6431346e I bump the version of ganache on aragon/aragen#24 then I tested aragonCLI locally doing npm link to the updated aragen branch...but I'm still getting this bug. Not sure if there are other changes I need to do to replicate the new aragen release

@sohkai
Copy link
Contributor

sohkai commented Jan 15, 2019

@galactusss You'd have to copy the snapshot that gets generated by aragen into the appropriate ~/.aragon folder.

This definitely seems like a really good reason to bump aragen now 👍.

@sohkai sohkai added the 🦅 high priority A signal from the teams to mark the importance of an issue to the maintainers label Jan 15, 2019
@kernelwhisperer
Copy link
Contributor Author

@sohkai I can't seem to get aragen working.

I cloned it and did npm install + npm start, but is crashing at scripts/deploy-base with: RangeError: Maximum call stack size exceeded.

Can we pin it back to 2.2.1 to be able to release?

@sohkai sohkai changed the title Cannot create dao on devchain Cannot create dao with [email protected] Jan 17, 2019
@sohkai
Copy link
Contributor

sohkai commented Jan 17, 2019

I've renamed this issue so we can keep this open as we try to upgrade aragen to [email protected] to see if this is still an issue.

@kernelwhisperer kernelwhisperer added cmd: devchain and removed 🦅 high priority A signal from the teams to mark the importance of an issue to the maintainers labels Apr 17, 2019
@0xGabi 0xGabi mentioned this issue May 8, 2019
6 tasks
@sohkai
Copy link
Contributor

sohkai commented May 18, 2019

@0xGabi Wondering if we can close this now that I think we've bumped the version used by aragen? Or if we haven't, should we try to update its ganache-core now?

@0xGabi
Copy link
Contributor

0xGabi commented May 18, 2019

@sohkai this is still an issue on [email protected].

/Users/gabrielgarcia/Code/Aragon/aragen/node_modules/ganache-core/lib/utils/gasEstimation.js:88
      rootBegin: steps.systemOps[begin][0],
                                       ^
TypeError: Cannot read property '0' of undefined
    at findRootScope (/Users/gabrielgarcia/Code/Aragon/aragen/node_modules/ganache-core/lib/utils/gasEstimation.js:88:40)

Note: We bump the version with green-keeper but we will need to pin it back. The new aragonCLI release still on ganache-corev2.2.1

@0xGabi
Copy link
Contributor

0xGabi commented May 19, 2019

I check with [email protected] and seems to be working.

Note: We also need to pin web3 1.0.0-beta.34.

@sohkai
Copy link
Contributor

sohkai commented May 19, 2019

It might be worth creating an issue over at ganache-core with some of the debug trace on v2.5.5 to help them.

@kernelwhisperer
Copy link
Contributor Author

I need to update dependencies in aragen as well.
(@sohkai would you mind enabling greenkeeper to that repo as well?)

After that we can test the new ganache-core and web3 versions, because now they're being deduped:

daniel@zen5-ub:~/r/aragon/aragon-cli$ npm ls -g ganache-core
/home/daniel/.npm-global/lib
└─┬ @aragon/[email protected]
  ├─┬ @aragon/[email protected]
  │ └── [email protected]  deduped
  └── [email protected] 

daniel@zen5-ub:~/r/aragon/aragon-cli$ npm ls -g web3
/home/daniel/.npm-global/lib
└─┬ @aragon/[email protected]
  ├─┬ @aragon/[email protected]
  │ └── [email protected]  deduped
  ├─┬ @aragon/[email protected]
  │ └─┬ [email protected]
  │   ├── [email protected] 
  │   └─┬ [email protected]
  │     └── [email protected] 
  ├─┬ @aragon/[email protected]
  │ ├─┬ [email protected]
  │ │ └── [email protected] 
  │ └── [email protected] 
  ├─┬ [email protected]
  │ └── [email protected] 
  ├─┬ [email protected]
  │ └── [email protected] 
  ├─┬ [email protected]
  │ └── [email protected] 
  └── [email protected] 

@kernelwhisperer kernelwhisperer self-assigned this May 21, 2019
@sohkai
Copy link
Contributor

sohkai commented May 21, 2019

@0x6431346e Greenkeeper is now enabled on aragen as well.

@0xGabi
Copy link
Contributor

0xGabi commented Jun 6, 2019

This was fixed with aragon/aragen#41

@0xGabi 0xGabi closed this as completed Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug An unexpected behavior of the API
Projects
None yet
Development

No branches or pull requests

3 participants