Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide uint64 time helpers #361

Closed
sohkai opened this issue Jul 16, 2018 · 1 comment
Closed

Provide uint64 time helpers #361

sohkai opened this issue Jul 16, 2018 · 1 comment
Assignees
@bingen @sohkai
Labels
audit: cd

Comments

@sohkai
Copy link
Contributor

sohkai commented Jul 16, 2018

We normally assume uint64 is enough for time (it should be...), but to be explicitly safe, we can also provide a safe conversion utility for uint256 -> uint64.

We should also add base contracts to supply both time and block number so the interface is consistent (and maybe even provide a mocked version for easier testing) in apps.
@sohkai sohkai self-assigned this Jul 16, 2018
@bingen bingen self-assigned this Jul 28, 2018
@bingen bingen mentioned this issue Jul 30, 2018
Merged
1 task
@bingen
Copy link
Contributor

bingen commented Jul 30, 2018

For reference: https://github.com/ConsenSys/aragon-apps-audit-repo/issues/38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bingen bingen

@sohkai sohkai

Labels
audit: cd
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bingen @sohkai