Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACLOracles: detect and include contextual error message #1433

Open
john-light opened this issue Jun 1, 2020 · 1 comment
Open

ACLOracles: detect and include contextual error message #1433

john-light opened this issue Jun 1, 2020 · 1 comment

Comments

@john-light
Copy link
Contributor

Is your feature request related to a problem? Please describe.
If a user is given an error, it'd be nice to make the error as descriptive as possible.

"You may not have the required permissions" doesn't tell the user much.

Here's a specific example:

Screenshot_2020-06-01 unknown png (PNG Image, 2008 × 964 pixels) - Scaled (82%)

This is from the Dandelion template. The specific problem is that the user did not have the Token Lock token (or enough of those tokens) to create a new vote.

A preferable error message would be something like:

You must have a minimum balance of 10 DAI to create a new vote.

There are other similar situations as well where we could be more descriptive about what exactly the issue is preventing a user from acting:

  • Do they need a token?
  • Do they need more tokens?
  • Do they need to be given permission directly?

If a user currently doesn't have permission to perform an action, let's give them the information they need so they know what they need to do to be able to take the action.

@john-light john-light changed the title Enable contextual errors Enable contextual error messages Jun 1, 2020
@sohkai sohkai changed the title Enable contextual error messages Dandelion: allow for contextual error signing panel messages Jun 7, 2020
@sohkai sohkai changed the title Dandelion: allow for contextual error signing panel messages ACLOracles: detect and include contextual error message Jun 7, 2020
@sohkai
Copy link
Contributor

sohkai commented Jun 7, 2020

This is similar to #1292, but I've repurposed this to be specific to ACLOracles.

The specific problem with Dandelion (and its usage of ACLOracles) results in similar symptoms to #1292, but can be solved separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants