Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce abi, and icon to top-level App objects #238

Open
sohkai opened this issue Aug 25, 2020 · 0 comments
Open

Introduce abi, and icon to top-level App objects #238

sohkai opened this issue Aug 25, 2020 · 0 comments

Comments

@sohkai
Copy link
Contributor

sohkai commented Aug 25, 2020

We should expose some easy-to-use APIs for fetching commonly-accessed metadata from App objects:

  • ABI
  • Icon (port over the code we have in the client)?
  • Human read-able name (not sure what App#name is returning at the moment—probably the aragonPM name?)

However, I'm not sure how useful the icon is over the general case, as developers may prefer their own assets / etc.

cc @andy-hook @bpierre


I couldn't find another issue for this, but this may also be a good place to start a discussion re-thinking the current data available from the App class.

Things I'm not sure about:

  • kernelAddress and Organization could probably be reduced to just Organization?
  • registry, registryAddress, repoAddress, version may be better encapsulated in a Repo class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant