Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SidePanel: add render prop with the open status #347

Closed
sohkai opened this issue Apr 9, 2019 · 3 comments · Fixed by #616
Closed

SidePanel: add render prop with the open status #347

sohkai opened this issue Apr 9, 2019 · 3 comments · Fixed by #616

Comments

@sohkai
Copy link
Contributor

sohkai commented Apr 9, 2019

See aragon/aragon-apps#717 (comment).

Nested components to the SidePanel will likely want to do different things based on whether or not it's opened.

@kushagrasharma
Copy link

Hi! I'm interested in working on this issue. Seems like a good place to start for someone new to the project.

Since I am new, what's the best way to get onboarded to contributing to Aragon UI/Aragon as a whole? I didn't see a contributors doc, are there best practices, tests, a chat, or anything else like that I should know about before diving in?

Thanks 😄

@bpierre
Copy link
Contributor

bpierre commented Jul 26, 2019

Hi @kushagrasharma, that’s great! Yes it would be nice to have access to this information, let me know if you want to discuss anything before opening your first PR!

Since I am new, what's the best way to get onboarded to contributing to Aragon UI/Aragon as a whole? I didn't see a contributors doc, are there best practices, tests, a chat, or anything else like that I should know about before diving in?

The chat is generally a good place to start with, you could join the #dev and #dev-frontend channels on https://aragon.chat/ (I am @bpierre there too).

A proper contributor’s guide is coming to aragonUI, but in the meantime, you can check these two documents:

Talk to you soon 🤗

@bpierre
Copy link
Contributor

bpierre commented Oct 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants