Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine UDFs into appropriate objects #187

Closed
greebie opened this issue Mar 28, 2018 · 2 comments
Closed

Combine UDFs into appropriate objects #187

greebie opened this issue Mar 28, 2018 · 2 comments

Comments

@greebie
Copy link
Contributor

greebie commented Mar 28, 2018

There are a few image udfs that could be combined into a single object rather than having multiple files.

For example, ComputeMD5 and ComputeImageSize might be better in a single object for image / byte array utilities. It would also distinguish ComputerMD5 (takes a byte array) from StringUtils.computeHash() (takes a string).

Suggested groupings could be:

  • imageUtils
  • String (or text) Utils (detect language, json output etc.)
  • Twitter-related Utils (detect @ mentions, hashtags etc.)
  • Network graph-related Utils
@greebie greebie changed the title Create image utility object Combine UDFs into appropriate objects Mar 28, 2018
@ruebot
Copy link
Member

ruebot commented Aug 14, 2018

With activity since April 2018, do we need to revisit this issue? Rewrite it, or close it?

@lintool @ianmilligan1

@ianmilligan1
Copy link
Member

Yeah, and a lot of that activity was @lintool’s major package restructuring. My instinct here is to close but I’d defer to Jimmy.

@lintool lintool closed this as completed Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants