Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create tests for ExtractGraph.scala #49

Closed
ruebot opened this issue Oct 2, 2017 · 6 comments
Closed

Create tests for ExtractGraph.scala #49

ruebot opened this issue Oct 2, 2017 · 6 comments
Assignees
@greebie
Labels
RA-Task tests

Comments

@ruebot
Copy link
Member

ruebot commented Oct 2, 2017

ExtractGraph.scala has no test coverage. We need to create tests for it.
@ruebot ruebot added the tests label Oct 2, 2017
@greebie greebie self-assigned this Oct 11, 2017
@greebie greebie mentioned this issue Oct 13, 2017
Merged
@ruebot
Copy link
Member Author

ruebot commented Oct 13, 2017

Partially resolved with: f28c6e1

@greebie greebie mentioned this issue Oct 19, 2017
Closed
@greebie
Copy link
Contributor

greebie commented Jan 11, 2018

This is up to 94%. I am lost as to why we do not have 100%, but it relates to the Edges & Nodes case classes.

@ruebot ruebot added the RA-Task label Feb 5, 2018
@ruebot
Copy link
Member Author

ruebot commented Aug 10, 2018

Looks like we need to account for both ExtractGraph and ExtractGraphX here?

https://codecov.io/gh/archivesunleashed/aut/src/master/src/main/scala/io/archivesunleashed/app/ExtractGraph.scala

https://codecov.io/gh/archivesunleashed/aut/src/master/src/main/scala/io/archivesunleashed/app/ExtractGraphX.scala

@greebie
Copy link
Contributor

greebie commented Aug 10, 2018

As part of #203 ExtractGraph has been deprecated. I can't remember why, but the tests have been commented out since it started.

I think we can leave this. Except that I like the name ExtractGraph over ExtractGraphX.

@greebie greebie mentioned this issue Nov 22, 2018
Closed
@ianmilligan1
Copy link
Member

With #291 merged, ExtractGraph has been removed in ab32df4.

ExtractGraphX coverage is at 92%. CodeCov here. Should we keep ticket open under new name to try to up that, or close?

@ruebot
Copy link
Member Author

ruebot commented Nov 29, 2018

Closed with ab32df4

ExtractGraphX issue: #294

@ruebot ruebot closed this as completed Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greebie greebie

Labels
RA-Task tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@greebie @ruebot @ianmilligan1