Use std::ffi everywhere instead of std::os::raw #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: spx01 <[email protected]>
|
@spx01 Thanks, this is great! Can you either run |
Signed-off-by: spx01 <[email protected]>
|
Done! |
AldaronLau
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
@spx01 Great! I just merged some code to get CI working again. Once those changes rebased or merged in, I can merge this
AldaronLau
added a commit
that referenced
this pull request
Jan 11, 2025
Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: spx01 <[email protected]> Co-authored-by: Jeron Aldaron Lau <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AldaronLau
added a commit
that referenced
this pull request
Jan 11, 2025
Signed-off-by: spx01 <[email protected]> Co-authored-by: Jeron Aldaron Lau <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 11, 2025
Signed-off-by: spx01 <[email protected]> Co-authored-by: spx01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace usage of
std::os::rawwithstd::ffifor C types.Fixes #75.