Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDNS text record encoding is not RFC compliant #42

Open
matthewgream opened this issue Oct 22, 2024 · 0 comments
Open

MDNS text record encoding is not RFC compliant #42

matthewgream opened this issue Oct 22, 2024 · 0 comments
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@matthewgream
Copy link

To reproduce:

  • review ArduinoMDNS code in sendMDNSmessage
  • observe the text record is encoded with only 16 bit length and then raw string
  • read https://www.ietf.org/rfc/rfc6763.txt to understand that text record encoding is specifically different in MDNS packets
  • read that text records must be inserted with each string prefixed by single byte length of string
  • observe that this is not carried out in ArduinoMDNS
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@per1234 @matthewgream