Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inefficient use of buffers #43

Open
matthewgream opened this issue Oct 22, 2024 · 0 comments
Open

Inefficient use of buffers #43

matthewgream opened this issue Oct 22, 2024 · 0 comments
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@matthewgream
Copy link

matthewgream commented Oct 22, 2024 •
edited by per1234
Loading

To reproduce:

  • review code to observe that UDP layer will allocate RX ring buffer
  • then ArduinoMDNS packet processing will malloc UDP buffer, process it, and free UDP buffer
  • enable debug logging in ArduinoMDNS to observe that buffers are allocated on MDNS packets that are to/from other devices on network
  • ArduinoMDNS does not efficiently only allocate buffers when packets are only for itself
  • furthermore, UDP layer supports byte by byte read from ring buffer

This makes the library not performant for small memory systems.
@per1234 per1234 changed the title MDNS is not performant for small memory systems Inefficient use of buffers Oct 23, 2024
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@per1234 @matthewgream