Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate settings module #215

Merged
merged 7 commits into from
May 7, 2017
Merged

Conversation

argaen
Copy link
Member

@argaen argaen commented May 6, 2017

Closes #214

@codecov-io
Copy link

codecov-io commented May 6, 2017

Codecov Report

Merging #215 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   98.92%   98.93%   +0.01%     
==========================================
  Files          12       12              
  Lines         652      660       +8     
  Branches       74       74              
==========================================
+ Hits          645      653       +8     
  Misses          7        7
Impacted Files Coverage Δ
aiocache/__init__.py 81.81% <100%> (ø) ⬆️
aiocache/factory.py 100% <100%> (ø) ⬆️
aiocache/settings.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa10818...c0f36a7. Read the comment docs.

@argaen argaen force-pushed the enhancement_#214/deprecate_settings_module branch 3 times, most recently from 940a992 to 1e128bd Compare May 7, 2017 11:09
@argaen argaen force-pushed the enhancement_#214/deprecate_settings_module branch from 1e128bd to 3ff6586 Compare May 7, 2017 11:18
@argaen argaen force-pushed the enhancement_#214/deprecate_settings_module branch from 157bae1 to 442758b Compare May 7, 2017 11:37
@argaen argaen force-pushed the enhancement_#214/deprecate_settings_module branch from 3a86a54 to c0f36a7 Compare May 7, 2017 11:48
@argaen argaen merged commit 8ccae99 into master May 7, 2017
@argaen argaen deleted the enhancement_#214/deprecate_settings_module branch May 7, 2017 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants