Cancel the previous ttl timer if exists when setting a new value in the in-memory cache #424
Conversation
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
==========================================
+ Coverage 99.77% 99.77% +<.01%
==========================================
Files 9 9
Lines 871 873 +2
Branches 95 96 +1
==========================================
+ Hits 869 871 +2
Misses 2 2
Continue to review full report at Codecov.
|
minhtule
force-pushed
the
fix_in_memory_ttl
branch
3 times, most recently
from
c58b60e to
86cb33e
Compare
minhtule
force-pushed
the
fix_in_memory_ttl
branch
from
86cb33e to
a65edb1
Compare
tests/acceptance/test_base.py
Outdated
|
|
||
| await asyncio.sleep(0.05) | ||
| assert await memory_cache.get(pytest.KEY) == "new_value" | ||
|
|
There was a problem hiding this comment.
Hey @minhtule lets move this test to TestCache and use the cache fixture. This way we ensure all backends behave in a consistent way :)
There was a problem hiding this comment.
That makes sense. I've moved the test there.
minhtule
force-pushed
the
fix_in_memory_ttl
branch
from
67f3598 to
935a911
Compare
|
@argaen I'm not sure why the 2 checks are still pending. Could you please take a look? Also I notice that the |
Yeah.. it happened to me sometimes too, if the build passes correctly (I've resync with master) I'll merge the changes
I know... It's been there for a while but haven't dedicated time to investigate TBH. Happy to accept PRs :D |
|
Merged, tomorrow I'll do a bugfix release, thanks :) |
|
Thank you @argaen ! |
|
@minhtule released yesterday with 0.10.1 |
|
Got it. Thank you @argaen ! |
This PR is branched out from the v0.10.0 version bump commit because there is some change on
master(e.g. 634348f) that is not backward compatible with0.10.0.