Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] review naming columns Steps: CombineColumns, CombineKeys, ExpandColumns #755

Closed
davidberenstein1957 opened this issue Jun 25, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@davidberenstein1957
Copy link
Member

Is your feature request related to a problem? Please describe.
The naming for these operations is a bit fragmented and not always as explicit/intuitive.

Describe the solution you'd like
I propose reviewing the naming and perhaps aligning it with a more familiar naming and API design like the one used in pandas.

  • ExpandColumns is nice and explicit, but I think pandas uses explode, so something like ExplodeColumns would perhaps be better.
  • CombineKeys uses the Keys in the name, but I think it would be better to go for something like AggregateColumns/ MergeColumns, AppendColumns
  • CombineColumns seems to groupby operation and not really a combination. Perhaps something like GroupByColumns might be better.

Open to iterating on the naming.

Describe alternatives you've considered
N.A.
Additional context
N.A.

@davidberenstein1957 davidberenstein1957 added bug Something isn't working enhancement New feature or request labels Jun 25, 2024
@plaguss
Copy link
Contributor

plaguss commented Jun 25, 2024

Hi! I think that can be useful too.

  • I think CombineKeys can be renamed to MergeColumns (this one would be the easiest, it's not released yet), it's more explicit, and it's really what it does.
    For the other two, I'm not sure we should follow the same naming convention as pandas:
  • CombineColumns I think it works fine with GroupColumns, not necessarily the GroupBy, the operation groups elements in a dictionary, but doesn't group elements in columns in the same sense of a pandas dataframe or a table.
  • ExpandColumns given that is explicit as it is, there's no need to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants