Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] mlx-lm integration #995

Closed
gabrielmbmb opened this issue Sep 23, 2024 · 2 comments · Fixed by #1089
Closed

[FEATURE] mlx-lm integration #995

gabrielmbmb opened this issue Sep 23, 2024 · 2 comments · Fixed by #1089
Labels
enhancement New feature or request
Milestone
1.5.0

Comments

@gabrielmbmb
Copy link
Member

Description

As suggested by @alvarobartt, it would be nice to integrate mlx-lm
@gabrielmbmb gabrielmbmb added the enhancement New feature or request label Sep 23, 2024
@gabrielmbmb gabrielmbmb added this to the 1.5.0 milestone Sep 23, 2024
@alvarobartt
Copy link
Member

Maybe this is a useful reference https://github.com/dottxt-ai/outlines/blob/515c1979b8507c6d70b07f3b8817e7c24cabfe09/outlines/models/mlxlm.py cc @gabrielmbmb @plaguss

@davidberenstein1957 davidberenstein1957 mentioned this issue Jan 8, 2025
Merged
@davidberenstein1957 davidberenstein1957 linked a pull request Jan 8, 2025 that will close this issue
add mlx support #1089
Merged
@davidberenstein1957 davidberenstein1957 mentioned this issue Jan 9, 2025
Merged
4 tasks
@plaguss
Copy link
Contributor

plaguss commented Jan 15, 2025

Done in #1089

@plaguss plaguss closed this as completed Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

add mlx support argilla-io/distilabel
3 participants
@gabrielmbmb @alvarobartt @plaguss