Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using a github app for credential #182

Closed
psimms-r7 opened this issue May 26, 2022 · 7 comments
Closed

Add support for using a github app for credential #182

psimms-r7 opened this issue May 26, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@psimms-r7
Copy link

image

@almereyda
Copy link

almereyda commented Jan 7, 2023

That would also work nice as credential template.

Screenshot 2023-01-07 at 01-19-15 Repositories _ Settings - Argo CD

@onematchfox onematchfox added the enhancement New feature or request label Jan 7, 2023
@philamente
Copy link
Contributor

philamente commented Feb 10, 2023

As we need this as well I am giving it a try - the api interfaces etc seem to be already there. So hopefully this serves as a good first attempt in golang.

Fork can be found here: https://github.com/philamente/terraform-provider-argocd

@almereyda
Copy link

This ^^ link is pointing to another location than it presents to the user. This one: https://github.com/philamente/terraform-provider-argocd, hopefully, doesn't.

@philamente
Copy link
Contributor

@onematchfox this issue/enhancement request can be closed btw ;)

What is your workflow for tagging a new release? Just asking as we might wait until we can pull it from terraform registry instead of having to use a local tf provider override.

@onematchfox
Copy link
Collaborator

What is your workflow for tagging a new release? Just asking as we might wait until we can pull it from terraform registry instead of having to use a local tf provider override.

How quickly do you need the functionality? I've been delaying cutting a new release in the hope of getting #229 into it. However @oboukili has limited time to dedicate to this project so ultimately I'm not sure how long it will take to get that reviewed. Would it work for you if I held off a couple more days and cut the release on Friday at the latest?

@philamente
Copy link
Contributor

Hey, Friday latest will work - no worries. Thanks! 👍

@onematchfox
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants