Build failures related to Node upgrade

[terrytangyuan]

Pre-requisites

• I have double-checked my configuration
• I can confirm the issues exists when I tested with :latest
• I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

https://github.com/argoproj/argo-workflows/actions/runs/5676125574/job/15383405669

 /home/runner/runners/2.306.0/externals/node16/bin/node: --openssl-legacy-provider is not allowed in NODE_OPTIONS

https://github.com/argoproj/argo-workflows/actions/runs/5676115276/job/15382363976

error [email protected]: The engine "node" is incompatible with this module. Expected version ">=20". Got "18.17.0"

Version

latest

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

Not needed

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

[agilgur5]

The snyk workflow needs to use Node v20 similar to the ci-build workflow's setup-node step. I'll write up a PR for that in a jiffy

[terrytangyuan]

The first issue is on publish-release workflow

[agilgur5]

Oh didn't realize the first one was a different workflow. That one's a weirder one since it's erroring on checkout before setup-node even runs 🤔

[agilgur5]

Oh... the version on the runner itself is failing to run checkout (which is in JS) due to the --openssl-legacy-provider. The reason it works during ci-build is because its NODE_OPTIONS is currently missing that flag.
EDIT: It doesn't need the flag anymore since the package.json#scripts now all have it in-line.
Also I see a decent amount of the UI deps are outdated now, Webpack (v4 -> v5) and React (v16 -> v18) being pretty core ones.

That's gonna take a few more changes to get working