-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backoff
under retryStrategy
does not work as expected for version 3.3.8
#9170
Comments
@dpadhiar Can you try to reproduce this issue? |
@sarabala1979 Yes. |
@sarabala1979 Confirmed backoff duration isn't working on 3.3.8. |
Hi @sarabala1979 @dpadhiar ! Do you think this can be fixed in a new release soon? It's the only thing preventing us from deploying to production so far. |
@raafatseif Yes, we will look into getting this fixed before 3.3.9/3.4 is released. |
To add to this, I've tested against v3.3.7 where the Backoff duration is working. This issue must have been introduced between v3.3.7 and v3.3.8. Could we also add a required unit test for this to prevent regression in the future? |
@HRusby I was able to reproduce the issue in v3.3.7 |
…ixes #9170. (#9213) * fix: retryStrategy.Limit is now read properly Signed-off-by: Dillen Padhiar <[email protected]> * test: add test case for backoff Signed-off-by: Dillen Padhiar <[email protected]> * chore: empty commit Signed-off-by: Dillen Padhiar <[email protected]> * test: update test case to check for certain amount of retries Signed-off-by: Dillen Padhiar <[email protected]> * test: added second case where limit is a string Signed-off-by: Dillen Padhiar <[email protected]>
…ixes #9170. (#9213) * fix: retryStrategy.Limit is now read properly Signed-off-by: Dillen Padhiar <[email protected]> * test: add test case for backoff Signed-off-by: Dillen Padhiar <[email protected]> * chore: empty commit Signed-off-by: Dillen Padhiar <[email protected]> * test: update test case to check for certain amount of retries Signed-off-by: Dillen Padhiar <[email protected]> * test: added second case where limit is a string Signed-off-by: Dillen Padhiar <[email protected]>
…ixes argoproj#9170. (argoproj#9213) * fix: retryStrategy.Limit is now read properly Signed-off-by: Dillen Padhiar <[email protected]> * test: add test case for backoff Signed-off-by: Dillen Padhiar <[email protected]> * chore: empty commit Signed-off-by: Dillen Padhiar <[email protected]> * test: update test case to check for certain amount of retries Signed-off-by: Dillen Padhiar <[email protected]> * test: added second case where limit is a string Signed-off-by: Dillen Padhiar <[email protected]> Signed-off-by: juchao <[email protected]>
…ixes argoproj#9170. (argoproj#9213) * fix: retryStrategy.Limit is now read properly Signed-off-by: Dillen Padhiar <[email protected]> * test: add test case for backoff Signed-off-by: Dillen Padhiar <[email protected]> * chore: empty commit Signed-off-by: Dillen Padhiar <[email protected]> * test: update test case to check for certain amount of retries Signed-off-by: Dillen Padhiar <[email protected]> * test: added second case where limit is a string Signed-off-by: Dillen Padhiar <[email protected]> Signed-off-by: Reddy <[email protected]>
The
backoff
feature forretryStrategy
does not behave as expected under version3.3.8
.The workflow was retried 10 times, but the wait time between each retry call was about 21 seconds.
Tested under version
3.2.4
, and it worked as expected.The text was updated successfully, but these errors were encountered: