-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reconcile wf when taskresult is added/updated. Fixes #10096 #10097
Merged
alexec
merged 1 commit into
argoproj:master
from
helio:taskresult-triggers-workflow-reconcile
Nov 24, 2022
Merged
fix: reconcile wf when taskresult is added/updated. Fixes #10096 #10097
alexec
merged 1 commit into
argoproj:master
from
helio:taskresult-triggers-workflow-reconcile
Nov 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd8796c
to
f65f1c5
Compare
Re-adds an EventHandler to trigger an update when a WorkflowTaskResult got added/updated. Without this, a workflow progress only gets updated upon completion or every 20mins. Fixes argoproj#10096, bug introduced in argoproj#8135 Reverts argoproj#8459 to re-add the progress test Signed-off-by: Michael Weibel <[email protected]>
f65f1c5
to
acffcbd
Compare
FTR:
|
alexec
approved these changes
Nov 24, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-adds an EventHandler to trigger an update when a WorkflowTaskResult got added/updated. Without this, a workflow progress only gets updated upon completion or every 20mins.
Fixes #10096
Reverts skipping of related Test (#8459)
Please do not open a pull request until you have checked ALL of these:
make pre-commit -B
to fix codegen and lint problems.