ci: add PR title conventional commits checker #10981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Xu <[email protected]>
| title-check: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: amannn/action-semantic-pull-request@v5 |
There was a problem hiding this comment.
Where is the configuration? Also need explicitly set permissions similar to ArgoCD https://github.com/argoproj/argo-cd/blob/master/.github/workflows/pr-title-check.yml
There was a problem hiding this comment.
@terrytangyuan No additional config file is required for this action amannn/action-semantic-pull-request.
Here are more details about comparison of the PR title checker:
- the argo-cd is using
thehanimo/pr-title-checker, which requires additional conf files. See https://github.com/argoproj/argo-cd/blob/master/.github/workflows/pr-title-check.yml - the argo-rollouts is using
amannn/action-semantic-pull-request, which doesn't require additional conf files and it's more popular and active maintained. See https://github.com/argoproj/argo-rollouts/blob/master/.github/workflows/pr-title-check.yml
Let's adopt the argo-rollouts one, but make it simpler inspired by https://github.com/microsoft/SynapseML/blob/master/.github/workflows/check-semantic-prs.yaml
terrytangyuan
approved these changes
Apr 26, 2023
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
61 tasks
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To provide the same contributing settings for Argo projects. since other projects like the argo-rollouts and argo-cd have already adopted the PR title checker to conform to conventional commits.