fix(ui): add query string to workflow detail page. Fixes #11371 #11373
Conversation
toyamagu-2021
force-pushed
the
fix-11371
branch
4 times, most recently
from
1687b69 to
f01053e
Compare
| @@ -352,6 +354,10 @@ export const WorkflowDetails = ({history, location, match}: RouteComponentProps< | |||
| ); | |||
| }; | |||
| useEffect(() => { | |||
| // If a workflow is archived, we don't need watch. | |||
| if (isWfInDB) { | |||
There was a problem hiding this comment.
We should do this here because workflows.watch calls getWorkflow in the serverside, which can cause error described in #11371 .
| @@ -377,18 +385,19 @@ export const WorkflowDetails = ({history, location, match}: RouteComponentProps< | |||
| ); | |||
| retryWatch.start(); | |||
| return () => retryWatch.stop(); | |||
| }, [namespace, name]); | |||
| }, [namespace, name, isWfInDB]); | |||
There was a problem hiding this comment.
Could you check if different cases for workflow deletion still work as before?
There was a problem hiding this comment.
I had checked. Do you mean UI interactively changes on the workflow events?
UI displays 'workflow gone' after GC.
And I've added a detailed verification in PR.
Don't hesitate to point out to me if some cases missing.
There was a problem hiding this comment.
I meant the workflow delete button:
- Delete only live workflow
- Also delete archived workflow (there will be a checkbox)
There was a problem hiding this comment.
There was a problem hiding this comment.
I'm thinking about a better way to make 'isInCluster=true'
This would depend on #11367 (comment)?
There was a problem hiding this comment.
Yes, it should depends on a issue.
I'll submit a PR in Friday, or in this weekend.
There was a problem hiding this comment.
As commented below, I checked this point with/without a checkbox.
- Without checkbox -> delete only live workflow (
Archived->Persisted) - With checkbox -> delete live workflow and archived workflow
The workflow can still be displayed since an archived workflow still exists, right? |
|
@toyamagu-2021 I saw your thumbs-up to my comments and just wondering if that means "I have tested and everything looks good" or "I will be testing it". |
|
@terrytangyuan
|
|
Let me know when this is ready for another review once you've done testing on the scenarios we discussed before. |
|
OK, I had some refactoring and additional following checks on the delete button.
|
agilgur5
changed the title
Signed-off-by: [email protected] [email protected]
Fixes #11371
Motivation
Modifications
uidto the workflow detail page.uidfrom the workflow list page.uidin the following functionsgetArchivedresubmitArchivedVerification
Resubmit Workflow
Workflow GC
URL:
http://localhost:8080/workflows/argo/omniscient-dragon?tab=workflowURL is set to:
http://localhost:8080/workflows/argo/omniscient-dragon?tab=summary&uid=4dd0192a-d976-4584-a13b-3e3a8eb196af