Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure target Workflow hooks not nil (#11521) #11535

Merged
merged 4 commits into from
Aug 7, 2023
Merged

fix: Ensure target Workflow hooks not nil (#11521) #11535

merged 4 commits into from
Aug 7, 2023

Conversation

toyamagu-2021
Copy link
Member

@toyamagu-2021 toyamagu-2021 commented Aug 6, 2023 •
edited
Loading

Fixes #11521

Motivation

  • Ensure target.spec.Hooks in MergeTo is not nil when we should patch

Modifications

  • make(map) if target.spec.Hooks is nil.
  • Add corresponding tests.

Verification

@toyamagu-2021 toyamagu-2021 force-pushed the fix-11521- branch 3 times, most recently from c5bf649 to 16906d1 Compare August 6, 2023 15:56
@toyamagu-2021 toyamagu-2021 changed the title fix: Ensure target Workflow hooks not nil fix: Ensure target Workflow hooks not nil (#11521) Aug 6, 2023
@toyamagu-2021 toyamagu-2021 mentioned this pull request Aug 6, 2023
Closed
3 tasks
@toyamagu-2021 toyamagu-2021 marked this pull request as ready for review August 6, 2023 16:52
@toyamagu-2021 toyamagu-2021 force-pushed the fix-11521- branch 2 times, most recently from 8d25a4a to adc4aba Compare August 7, 2023 11:47
@toyamagu-2021
fix: increase e2e test time
3ade8f8 
Signed-off-by: toyamagu-2021 <[email protected]>
terrytangyuan
terrytangyuan approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@toyamagu-2021
Copy link
Member Author

toyamagu-2021 commented Aug 7, 2023 •
edited
Loading

I increased the e2e-test time to 30 min since it reaches the time limit.
https://github.com/argoproj/argo-workflows/actions/runs/5784694803?pr=11535

@toyamagu-2021
chore: empty commit
67aa2a2 
Signed-off-by: toyamagu-2021 <[email protected]>
@toyamagu-2021 toyamagu-2021 mentioned this pull request Aug 7, 2023
Merged
@terrytangyuan terrytangyuan merged commit 545bf38 into argoproj:master Aug 7, 2023
@terrytangyuan terrytangyuan mentioned this pull request Aug 9, 2023
Closed
45 tasks
terrytangyuan pushed a commit that referenced this pull request Aug 11, 2023
@toyamagu-2021 @terrytangyuan
fix: Ensure target Workflow hooks not nil (#11521) (#11535)
f4ede0a
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request May 9, 2024
@toyamagu-2021 @dpadhiar
fix: Ensure target Workflow hooks not nil (argoproj#11521) (argoproj#…
c3364ff 
…11535)

Signed-off-by: Dillen Padhiar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
area/hooks area/workflow-templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting Error: assignment to entry in nil map when hooks are used
3 participants
@toyamagu-2021 @terrytangyuan @agilgur5