fix: prevent backoff when retryStrategy.limit has been reached. Fixes #7588 #8090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simster7
previously requested changes
Mar 7, 2022
alexec
requested changes
Mar 10, 2022
rohankmr414
force-pushed
the
retry-strategy-limit
branch
2 times, most recently
from
8b8290a to
ca3046e
Compare
|
@alexec I've added the missing tests for retry limit can you please review it? |
alexec
reviewed
Apr 5, 2022
alexec
reviewed
Apr 5, 2022
alexec
approved these changes
Apr 5, 2022
rohankmr414
force-pushed
the
retry-strategy-limit
branch
from
751da2b to
36bc374
Compare
…Fixes argoproj#7588 Signed-off-by: Rohan Kumar <[email protected]>
Signed-off-by: Rohan Kumar <[email protected]>
Signed-off-by: Rohan Kumar <[email protected]>
Signed-off-by: Rohan Kumar <[email protected]>
auto-merge was automatically disabled
April 12, 2022 20:31
Head branch was pushed to by a user without write access
rohankmr414
force-pushed
the
retry-strategy-limit
branch
from
36bc374 to
4677fa3
Compare
alexec
approved these changes
Apr 14, 2022
Closed
alexec
pushed a commit
that referenced
this pull request
May 3, 2022
…7588 (#8090) Signed-off-by: Rohan Kumar <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rohan Kumar [email protected]
Fixes #7588