Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update workflowtaskresult code have own reconciliation loop. #8135

Merged
merged 6 commits into from
Mar 18, 2022

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Mar 12, 2022

Signed-off-by: Alex Collins [email protected]

  • It is possible (but unlikely) for the pod informer to be up-to-date, but the task-result informer out-of-date. This addresses that.
  • Fix an instance ID bug.

Depended on by #8120

alexec added 4 commits March 12, 2022 15:48
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec marked this pull request as ready for review March 13, 2022 18:55
@alexec alexec enabled auto-merge (squash) March 13, 2022 18:55
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec requested a review from terrytangyuan March 17, 2022 14:55
@alexec alexec merged commit 41fd07a into argoproj:master Mar 18, 2022
@alexec alexec deleted the inf branch March 18, 2022 04:23
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request Mar 23, 2022
@sarabala1979 sarabala1979 mentioned this pull request Apr 14, 2022
85 tasks
sarabala1979 pushed a commit that referenced this pull request Apr 18, 2022
mweibel added a commit to helio/argo-workflows that referenced this pull request Nov 22, 2022
Re-adds an EventHandler to trigger an update when a WorkflowTaskResult
got added/updated. Without this, a workflow progress only gets updated
upon completion or every 20mins.

Fixes argoproj#10096, bug introduced in argoproj#8135

Signed-off-by: Michael Weibel <[email protected]>
mweibel added a commit to helio/argo-workflows that referenced this pull request Nov 24, 2022
Re-adds an EventHandler to trigger an update when a WorkflowTaskResult
got added/updated. Without this, a workflow progress only gets updated
upon completion or every 20mins.

Fixes argoproj#10096, bug introduced in argoproj#8135
Reverts argoproj#8459 to re-add the progress test

Signed-off-by: Michael Weibel <[email protected]>
mweibel added a commit to helio/argo-workflows that referenced this pull request Nov 24, 2022
Re-adds an EventHandler to trigger an update when a WorkflowTaskResult
got added/updated. Without this, a workflow progress only gets updated
upon completion or every 20mins.

Fixes argoproj#10096, bug introduced in argoproj#8135
Reverts argoproj#8459 to re-add the progress test

Signed-off-by: Michael Weibel <[email protected]>
mweibel added a commit to helio/argo-workflows that referenced this pull request Nov 24, 2022
Re-adds an EventHandler to trigger an update when a WorkflowTaskResult
got added/updated. Without this, a workflow progress only gets updated
upon completion or every 20mins.

Fixes argoproj#10096, bug introduced in argoproj#8135
Reverts argoproj#8459 to re-add the progress test

Signed-off-by: Michael Weibel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants