-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update workflowtaskresult
code have own reconciliation loop.
#8135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
sarabala1979
approved these changes
Mar 18, 2022
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
Mar 23, 2022
…rgoproj#8135) Signed-off-by: Alex Collins <[email protected]>
sarabala1979
pushed a commit
that referenced
this pull request
Apr 18, 2022
…8135) Signed-off-by: Alex Collins <[email protected]>
3 tasks
mweibel
added a commit
to helio/argo-workflows
that referenced
this pull request
Nov 22, 2022
Re-adds an EventHandler to trigger an update when a WorkflowTaskResult got added/updated. Without this, a workflow progress only gets updated upon completion or every 20mins. Fixes argoproj#10096, bug introduced in argoproj#8135 Signed-off-by: Michael Weibel <[email protected]>
mweibel
added a commit
to helio/argo-workflows
that referenced
this pull request
Nov 24, 2022
Re-adds an EventHandler to trigger an update when a WorkflowTaskResult got added/updated. Without this, a workflow progress only gets updated upon completion or every 20mins. Fixes argoproj#10096, bug introduced in argoproj#8135 Reverts argoproj#8459 to re-add the progress test Signed-off-by: Michael Weibel <[email protected]>
mweibel
added a commit
to helio/argo-workflows
that referenced
this pull request
Nov 24, 2022
Re-adds an EventHandler to trigger an update when a WorkflowTaskResult got added/updated. Without this, a workflow progress only gets updated upon completion or every 20mins. Fixes argoproj#10096, bug introduced in argoproj#8135 Reverts argoproj#8459 to re-add the progress test Signed-off-by: Michael Weibel <[email protected]>
mweibel
added a commit
to helio/argo-workflows
that referenced
this pull request
Nov 24, 2022
Re-adds an EventHandler to trigger an update when a WorkflowTaskResult got added/updated. Without this, a workflow progress only gets updated upon completion or every 20mins. Fixes argoproj#10096, bug introduced in argoproj#8135 Reverts argoproj#8459 to re-add the progress test Signed-off-by: Michael Weibel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Collins [email protected]
Depended on by #8120