fix: install.yaml missing crb subject ns #8280
Conversation
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
gdsoumya
requested review from
terrytangyuan,
alexec and
jessesuen
and removed request for
terrytangyuan and
alexec
|
@gdsoumya Why exactly we are hardcoding the namespace for cluster install ? whoever refers the cluster install can mention the namespace in their own kustomization.yaml |
|
@tiwarisanjay the install.yaml file is supposed to be used directly for installing argo workflows, as pointed out in the examples this file should be okay to just use with You can still get your kustomization to work by replicating this Kustomization file and updating it with your ns. My Pr just makes sure the generated install.yaml is a valid k8s manifest that can be directly installed. |
|
@gdsoumya Yes, Apologies for install.yaml bug I introduced, as it was showing diff when I was fixing kustomize. But isn't kustomize supposed to be for generic use instead of hard-coding a namespace. |
|
@tiwarisanjay no worries, agreed I did not revert all your changes. The only thing I changed was that I added the ns in the cluster install kustomization - the individual base files are still without ns. We need to do this because the kustomization is used to generate the install.yaml which needs the ns there. |
|
@gdsoumya can you please direct me to code where we are running kustomize command to generate install.yaml file? I will try to fix the same by passing namespace. It will help us to make our cluster-install generic for any one to use. |
|
You can use |
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
Versions of Argo workflows after v3.3.4 appear to have a namespace added to their install.yaml resources (see argoproj/argo-workflows#8280 and argoproj/argo-workflows#8250 (comment)), with causes an error when kustomization tries to apply updates: ``` ComparisonError rpc error: code = Unknown desc = Manifest generation error (cached): `kustomize build /tmp/https___github.com_climateimpactlab_downscalecmip6/infrastructure/kubernetes-gcp/argo` failed exit status 1: Error: no matches for Id ~G_v1_ConfigMap|~X|workflow-controller-configmap; failed to find unique target for patch ~G_v1_ConfigMap|workflow-controller-configmap 2022-06-02 18:16:15 -0700 PDT ``` This *might* relate to a bug in customization (see kubernetes-sigs/kustomize#1332). So we're specifying the namespace in the install.yaml resource when defining the patch for the customization with the hopes that it will be able to find its target.
This PR fixes the issue with missing ns in crb subjects inside the
install.yamlfile, introduced in PR #8266ref: #8250 (comment)