test: Skip TestLoggedProgress.
#8459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <[email protected]>
terrytangyuan
approved these changes
Apr 22, 2022
mweibel
added a commit
to helio/argo-workflows
that referenced
this pull request
Nov 24, 2022
Re-adds an EventHandler to trigger an update when a WorkflowTaskResult got added/updated. Without this, a workflow progress only gets updated upon completion or every 20mins. Fixes argoproj#10096, bug introduced in argoproj#8135 Reverts argoproj#8459 to re-add the progress test Signed-off-by: Michael Weibel <[email protected]>
mweibel
added a commit
to helio/argo-workflows
that referenced
this pull request
Nov 24, 2022
Re-adds an EventHandler to trigger an update when a WorkflowTaskResult got added/updated. Without this, a workflow progress only gets updated upon completion or every 20mins. Fixes argoproj#10096, bug introduced in argoproj#8135 Reverts argoproj#8459 to re-add the progress test Signed-off-by: Michael Weibel <[email protected]>
8 tasks
mweibel
added a commit
to helio/argo-workflows
that referenced
this pull request
Nov 24, 2022
Re-adds an EventHandler to trigger an update when a WorkflowTaskResult got added/updated. Without this, a workflow progress only gets updated upon completion or every 20mins. Fixes argoproj#10096, bug introduced in argoproj#8135 Reverts argoproj#8459 to re-add the progress test Signed-off-by: Michael Weibel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Collins [email protected]
This test is still flakey. #8458