fix: Support memoization on plugin node. Fixes #8553 #8554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wujayway <[email protected]>
wujayway
changed the title
Signed-off-by: wujayway <[email protected]>
Signed-off-by: wujayway <[email protected]>
alexec
reviewed
Apr 30, 2022
| @@ -134,6 +137,13 @@ func (woc *wfOperationCtx) reconcileTaskSet(ctx context.Context) error { | |||
| node.FinishedAt = metav1.Now() | |||
|
|
|||
| woc.wf.Status.Nodes[nodeID] = node | |||
| if node.MemoizationStatus != nil && node.Succeeded() { | |||
alexec
changed the title
Signed-off-by: wujayway <[email protected]>
Signed-off-by: wujayway <[email protected]>
alexec
reviewed
May 1, 2022
|
|
||
| func TestReconcileTaskSetWithMemoization(t *testing.T) { | ||
| wf := wfv1.MustUnmarshalWorkflow(`apiVersion: argoproj.io/v1alpha1 | ||
| kind: Workflow |
There was a problem hiding this comment.
This example's length makes it too hard to understand what is the example is relevant to the test, and what is just copied and pasted. Can you please simplify.
Signed-off-by: wujayway <[email protected]>
Signed-off-by: wujayway <[email protected]>
alexec
reviewed
May 1, 2022
| @@ -829,24 +829,40 @@ func TestWorkflow_SearchArtifacts(t *testing.T) { | |||
| queriedArtifactSearchResults := wf.SearchArtifacts(query) | |||
| assert.NotNil(t, queriedArtifactSearchResults) | |||
| assert.Len(t, queriedArtifactSearchResults, 3) | |||
| assert.Equal(t, "artifact-foo", queriedArtifactSearchResults[0].Artifact.Name) | |||
There was a problem hiding this comment.
@rohankmr414 maybe this is the fix?
alexec
approved these changes
May 2, 2022
Closed
alexec
pushed a commit
that referenced
this pull request
May 3, 2022
Signed-off-by: wujayway <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wujayway [email protected]
Fixes #8553