Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle omitted nodes in DAG enhanced depends logic. Fixes #8654 #8672

Merged
merged 2 commits into from
May 6, 2022
Merged

fix: Handle omitted nodes in DAG enhanced depends logic. Fixes #8654 #8672

merged 2 commits into from
May 6, 2022

Conversation

terrytangyuan
Copy link
Member

Fixes #8654.

Signed-off-by: Yuan Tang [email protected]

@terrytangyuan terrytangyuan changed the title feat: Handle omitted nodes in DAG enhanced depends logic. Fixes #8654 fix: Handle omitted nodes in DAG enhanced depends logic. Fixes #8654 May 6, 2022
@terrytangyuan
fix: test
24f9184 
Signed-off-by: Yuan Tang <[email protected]>
@terrytangyuan terrytangyuan merged commit 70f7020 into argoproj:master May 6, 2022
@terrytangyuan terrytangyuan deleted the handle-omitted-dag branch May 6, 2022 21:34
@terrytangyuan terrytangyuan mentioned this pull request May 6, 2022
Closed
3 tasks
@luke-hemisphere
Copy link

@terrytangyuan does this also add TaskResults.Omitted to the convenience function mentioned in the docs?

existing docs:

For convenience, if an omitted task result is equivalent to (task.Succeeded || task.Skipped || task.Daemoned).

@sarabala1979 sarabala1979 mentioned this pull request May 25, 2022
Closed
14 tasks
sarabala1979 pushed a commit that referenced this pull request May 25, 2022
@terrytangyuan @sarabala1979
fix: Handle omitted nodes in DAG enhanced depends logic. Fixes #8654 (#…
2b428be 
…8672)

* feat: Handle omitted nodes in DAG enhanced depends logic. Fixes #8654

Signed-off-by: Yuan Tang <[email protected]>

* fix: test

Signed-off-by: Yuan Tang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhanced depends logic not working when task is omitted
3 participants
@terrytangyuan @luke-hemisphere @alexec