"panic: runtime error: index out of range" on release versions

[Nightliss]

Hi @SrKomodo

Any version for windows after 1.5.8 is giving me this:

Was GUI removed?

OS: Windows 10 x64 Home v1803

[arguablykomodo]

it was an error in the windows manifest file, the latest version should work

[Nightliss]

Still getting same error with 1.7.3 though. Both x32 and x64

[arguablykomodo]

oof, im gonna keep looking at it then

[Nightliss]

This is from windows eventlog.

[arguablykomodo]

Alright i think i know what's happening. Windows expects the version to have four digits. Should be an easy fix

[SW1FT]

Now it just quits instantly after you launch the executable.

[Nightliss]

Got this now:

[arguablykomodo]

Alright now i am completely lost, the issue only seems to happen from the released versions. When compiled from source, the program runs normally. I'm gonna keep looking into this

[arguablykomodo]

the problem shows up on linux too

[SW1FT]

1.7.8 works for me now.

[arguablykomodo]

Alright, after a day of furiously writing code, and a complete remodelation of the build system, the issue has been finally solved. Also this whole ordeal brought down the number of false antivirus alerts significantly.

The homebrew tap has yet to be updated, i will work on that tomorrow.

Pinging @overdodactyl for updating the version number on the website, literally 10 versions of the program were released today.

[overdodactyl]

Thanks for all the changes @SrKomodo! It's really appreciated. Bringing the number of false positives down will definitely be a noticed benefit for a lot of people as well.

The website should be up-to-date with the latest version at this point.

With some of the recent added options and the cli - really great addition by the way - I was going to put together a little documentation. I'll definitely add it to the website, but do you want me to send a PR for it on this repo or think it would be better suited on the Shadowfox one?

[arguablykomodo]

I think it would be better to have the documentation in the readme of this repo

[arguablykomodo]

also pinging @Remedan just in case something has to be done in the AUR package, the release files have different filenames now, and I'm not sure how AUR packages work.

[arguablykomodo]

Also-also, since it seems i am just using this issue for communication, @overdodactyl i added detailed documentation to the README, we should try to refer to that file wherever possible in the main repo and the wiki instead of repeating information over and over again.

[overdodactyl]

The README looks great, I think you're probably right it - it would be best to keep the info consolidated there; I won't add it to the website and I'll remove most of the info that's currently in the main repo/wiki.

I think the only other addition might be adding the info about placing it in the profile directory for non-traditional installs/Firefox forks (installs via Snap, Waterfox, Tor etc)

[arguablykomodo]

I just added some more info regarding common issues

[overdodactyl]

Looks great, thanks!

The ShadowFox README, wiki and website all point there now instead of having instructions.