Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "auto approve" option to schema apply command #519

Closed
ericyd opened this issue Jan 27, 2022 · 4 comments · Fixed by #526
Closed

Add "auto approve" option to schema apply command #519

ericyd opened this issue Jan 27, 2022 · 4 comments · Fixed by #526

Comments

@ericyd
Copy link
Contributor

ericyd commented Jan 27, 2022

Type

Feature request

Background

My interest in Atlas is to streamline our CI flow. We currently prepare a database in our CI environment and run migrations sequentially before our tests run. This takes about 25-30 seconds whereas atlas schema apply takes a fraction of a second. However, for this to work in a CI environment, there needs to be a command line option to "auto-approve" the schema application.

Details

  • Add a flag to the schema apply command that approves the schema application without prompting for user input
@a8m
Copy link
Member

a8m commented Jan 27, 2022

Hey hey @ericyd 👋

cc'ing @rotemtam and @yonidavidson as they wanted to add this, and they can help you contribute this change to atlas if you like (should be pretty simple). Thanks 🙏

@rotemtam
Copy link
Member

hey @ericyd ,

thanks for the feedback!

I would love to see this added to the schema apply command. It should be a quick fix, if you would like to contribute to the project, this can be a great start! If so, ping me on our discord server. Otherwise we will probably add it in next week's release.

In the meantime, you can do something like:

echo "\n" | atlas schema apply ...

@ericyd
Copy link
Contributor Author

ericyd commented Jan 27, 2022

seems like a very promising project, I'm excited about the work that has already been put in. I'll try to make time tomorrow to pursue a fix and I'll reach out on Discord before I do

@rotemtam
Copy link
Member

That's great! Looking forward to working on this with you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants