Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free Applicative #164

Closed
pakoito opened this issue Aug 1, 2017 · 1 comment
Closed

Free Applicative #164

pakoito opened this issue Aug 1, 2017 · 1 comment

Comments

@pakoito
Copy link
Member

pakoito commented Aug 1, 2017

I need to start a discussion before continuing with the implementation, as cats has recently done a refactor-overhaul themselves. The new version is stack-safe, performs better, and reads worse than anything else in our repo.

Reasoning for refactor: typelevel/cats#1151 (comment)

PR: typelevel/cats#1748

Implementation: typelevel/cats@693f456#diff-19bafa82f16b79d5e02c62e0d1612d28R39

The scalaz counterpart: https://github.com/scalaz/scalaz/blob/series/7.3.x/core/src/main/scala/scalaz/FreeAp.scala

@pakoito pakoito self-assigned this Aug 1, 2017
@raulraja raulraja mentioned this issue Aug 1, 2017
54 tasks
@raulraja
Copy link
Member

raulraja commented Aug 1, 2017

I think that if the new version by Edmund in Scala is stack-safe that is more important than the implementation readability and ours should resemble that one instead of the previous one. Kategory is a general purpose library that is ment to serve as companion to the stdlib stack-safety and performance is a concern most of our users are going to care and impure and dirty impls to achieve that is a fair trade-off because : FP in the JVM xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants