Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: untranslated yes/no choice in some settings tabs #1772

Closed
thomaskerboul opened this issue Mar 12, 2024 · 0 comments · Fixed by #1779
Closed

Problem: untranslated yes/no choice in some settings tabs #1772

thomaskerboul opened this issue Mar 12, 2024 · 0 comments · Fixed by #1779
Assignees
Labels
good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Milestone

Comments

@thomaskerboul
Copy link

Current Behavior

Sorry if anything isn't done correctly, this is my first time using git.
Currently in several settings tabs the yes/no choice is untranslated. A check on Weblate didn't yield any missing string in that regard. This concern the tabs:

  • DIP upload settings
  • Global
  • Markdown
  • Permissions
  • Security

image
Other tabs are fine; on e.g. Identifiers, the option is translated.

image

The behaviour is observed with every language other than english.

Expected Behavior

The yes/no choice should be translated.

Possible Solution

I'm not a developer, so I can only suggest that the hardcoding of 'yes' and 'no' in lib/form/SettingsGlobalForm.class.php might have to do with it. On the other hand apps/qubit/modules/settings/templates/identifierSuccess.php doesn't have any of those.

Context and Notes

No response

Version used

2.8.0 - 193

Operating System and version

No response

Default installation culture

fr

PHP version

No response

Contact details

No response

@thomaskerboul thomaskerboul added the Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. label Mar 12, 2024
@thomaskerboul thomaskerboul changed the title Problem: Problem: untranslated yes/no choice in some settings tabs Mar 13, 2024
@eviau-artefactual eviau-artefactual added the good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. label Mar 13, 2024
@melaniekung melaniekung self-assigned this Mar 18, 2024
@melaniekung melaniekung linked a pull request Mar 19, 2024 that will close this issue
@anvit anvit added this to the 2.8.2 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants