Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome v. 43 issue #4

Open
MarcinPcee opened this issue Jul 3, 2015 · 7 comments
Open

Chrome v. 43 issue #4

MarcinPcee opened this issue Jul 3, 2015 · 7 comments

Comments

@MarcinPcee
Copy link

Hi,
Script is not working on Chrome v. 43.0.2357.130.
No issue on Firefox 39.0 and IE 11.

Anybody beside me affected?

@mariapaulinar
Copy link

Me. I tried testing it in Chrome v. 43.0.2357.134 and I got same problem.

@arteyazilim
Copy link
Owner

I have tested on chrome 44. there is no issue. I couldn't find older version of chrome as 43.
Can you check on console panel (F12) to see is there any error message?

@tommiehansen
Copy link

Also no go in Chrome 46 for some reason. Working fine @ Chrome 45 at work though. Strangely the plugin just fails silently (no errors at console).

@tommiehansen
Copy link

I see the error now. The problem is that my computer at home has a touchscreen and your plugin seem to think that any device with a touchscreen doesn't have a mouse and keyboard which makes your plugin fail:

touchDevice = !!('ontouchstart' in document[0].documentElement)

This is an ugly workaround:

touchDevice = !!('ontouchstart' in document[0].documentElement && screen.width < 1200),

@arteyazilim
Copy link
Owner

It should work now. can you test with version 2 please?

@tommiehansen
Copy link

Couldn't get that one to work at all at the computer at work (without touchscreen). Haven't had time to test it at home yet though. Tested here with Chrome v45.

An odd thing is that the plugin always seem to fail silently like there is some check that doesn't pass.

@arteyazilim
Copy link
Owner

sorry, i can't find any touch device with mouse. i hope it works now (with last update).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants