Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some rustdoc examples are missing from code coverage #346

Closed
lopopolo opened this issue Aug 20, 2022 · 0 comments · Fixed by #347
Closed

Some rustdoc examples are missing from code coverage #346

lopopolo opened this issue Aug 20, 2022 · 0 comments · Fixed by #347
Labels
C-bug Category: This is a bug. E-help-wanted Call for participation: Help is requested to fix this issue.

Comments

@lopopolo
Copy link
Member

The code coverage infra uses an unstable rustdoc flags to persist doc tests as source files so grcov can merge coverage results.

It looks like if a doc comment on an item has multiple examples, only one of them is picked up by grcov.

Example: https://codecov.artichokeruby.org/boba/src/lib.rs.html#218.

Linking rustdoc persist tests tracking issue:
@lopopolo lopopolo added C-bug Category: This is a bug. E-help-wanted Call for participation: Help is requested to fix this issue. labels Aug 20, 2022
@lopopolo lopopolo mentioned this issue Aug 20, 2022
Open
5 tasks
@x-hgg-x x-hgg-x mentioned this issue Aug 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. E-help-wanted Call for participation: Help is requested to fix this issue.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use %p in LLVM_PROFILE_FILE for code coverage
1 participant
@lopopolo