Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document what it means to be a maintainer #491

Open
lopopolo opened this issue May 31, 2023 · 4 comments
Open

Document what it means to be a maintainer #491

lopopolo opened this issue May 31, 2023 · 4 comments
Assignees
Labels
A-project Area: Infrastructure for running an open source project. C-docs Category: Improvements or additions to documentation.

Comments

@lopopolo
Copy link
Member

In addition to myself, the @artichoke organization has several other members with commit rights that are part of the @artichoke/contributors group.

Add docs that outline this role, how to be granted it, and what it means to hold this role.

cc @b-n @choznerol

@lopopolo lopopolo added C-docs Category: Improvements or additions to documentation. A-project Area: Infrastructure for running an open source project. labels May 31, 2023
@lopopolo lopopolo self-assigned this May 31, 2023
@b-n
Copy link
Member

b-n commented May 31, 2023

Some random thoughts:

  • Continual contribution to the project - be it in commits, reviews, issues, social (discord).
  • Contributes in decisions to structural changes in the project w.r.t creation/addition of new packages, contributing guidelines, code of conduct (if there is one formed for example)
  • Protects the maintainability of the project - specifically w.r.t ensuring code reviews are good, helping others to contribute, etc?

I have the thought of "being available for brainstorming" or something to that degree.

@lopopolo
Copy link
Member Author

lopopolo commented Jun 2, 2023

Some other thoughts we discussed on Discord:

  • What a maintainer doesn't stop you from doing?
  • @lopopolo to grant maintainers group commit access to project-infrastructure (this bit of config is probably a bit stale and should be audited)
  • part of this should probably be documenting the things that only @lopopolo has perms to do (GH Admin, other GH orgs, npm scope, crate publishing, AWS, domain registrations/DNS)

@lopopolo
Copy link
Member Author

lopopolo commented Jun 2, 2023

The code for granting the maintainers group commit access to repos is here:

resource "github_team_repository" "contributor_repos" {
for_each = toset([
"artichoke",
"boba",
"cactusref",
"clang-format",
"focaccia",
"intaglio",
"jasper",
"mspec",
"playground",
"qed",
"rand_mt",
"raw-parts",
"roe",
"ruby",
"ruby-file-expand-path",
"spec",
"strftime-ruby",
"strudel",
])
team_id = module.team_contributors.team_id
repository = each.value
permission = "push"
}

@choznerol
Copy link
Member

  • What a maintainer doesn't stop you from doing?

I like and find the "Artichoke shouldn't be a maintainers sole contribution project etc" example provided in the thread makes this point clear 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-project Area: Infrastructure for running an open source project. C-docs Category: Improvements or additions to documentation.
Development

No branches or pull requests

3 participants