You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
Currently, we use org.asciidoctor.jruby.AsciiDocDirectoryWalker and org.asciidoctor.jruby.DirectoryWalker to obtain AsciiDoc sources from the paths. But his classes are not part of the asciidoctorj-api but the jruby implementation, this breaks encapsulation and prevents the plugin from working with other AsciidoctorJ implementations using the service loader.
We should replace this by some agnostic piece with same functionality, for example FileUtils.listFiles.
No problem 👍 My only suggestion is if you have a long running PR, just mark as "Draft" so people is aware is not finished. But even that's opinionated and some ppl prefer not getting the PR untill is finished 🤷
I can't promise I can look into the issue today, but I'll try.
abelsromero
changed the title
Remove usage of jruby DirectoryWalker
Remove usage of internal Asciidoctorj DirectoryWalker
Jul 7, 2021
What is this issue about?
Description
Currently, we use
org.asciidoctor.jruby.AsciiDocDirectoryWalker
andorg.asciidoctor.jruby.DirectoryWalker
to obtain AsciiDoc sources from the paths. But his classes are not part of the asciidoctorj-api but the jruby implementation, this breaks encapsulation and prevents the plugin from working with other AsciidoctorJ implementations using the service loader.We should replace this by some agnostic piece with same functionality, for example FileUtils.listFiles.
Reference:
asciidoctor-maven-plugin/src/main/java/org/asciidoctor/maven/AsciidoctorMojo.java
Lines 439 to 450 in 2a79b16
PD: there are other jruby specifics being used, but we can treat them in another issue.
The text was updated successfully, but these errors were encountered: